Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic working video #1

Closed
wants to merge 3 commits into from
Closed

Basic working video #1

wants to merge 3 commits into from

Conversation

domneedham
Copy link
Collaborator

Adds a reload functionality when the ice state gets stuck loading.

Being I don't have experience with RN, not sure if this code is "best practice". Feel to free take and amend or suggest changes. For now, thought it was good to just get it so video will always load.

@billyjacoby
Copy link
Owner

Heck yeah dude, this is working as expected for me too! Gonna make a few React specific cleanups and get this into main!

@billyjacoby
Copy link
Owner

Heck yeah dude, this is working as expected for me too! Gonna make a few React specific cleanups and get this into main!

I may have spoken too soon, this is definitely giving better results than before, but for me it seems like it's consistently taking at least 5-10 tries to connect so I wonder if this is just eventually falling on the right stream.

@billyjacoby billyjacoby mentioned this pull request Sep 9, 2023
Merged
@billyjacoby
Copy link
Owner

Closing in favor of #2

@billyjacoby billyjacoby closed this Sep 9, 2023
@domneedham
Copy link
Collaborator Author

Heck yeah dude, this is working as expected for me too! Gonna make a few React specific cleanups and get this into main!

I may have spoken too soon, this is definitely giving better results than before, but for me it seems like it's consistently taking at least 5-10 tries to connect so I wonder if this is just eventually falling on the right stream.

Yeah there is definitely something wrong with the opening of the ice candidate, it gets stuck a lot, hence the retry which eventually gets the connected ice connection.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@domneedham @billyjacoby